Skip to content

Conversation

@Archmonger
Copy link
Contributor

Description

Fixed a bug where use_async_effect cleanup functions were not being executed when dependencies changed.

This required removing shutdown_timeout parameter from use_async_effect. It is now up to the user to shield against asyncio.CancelledError for sensitive operations (such as database queries).

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger changed the title fix use_async_effect cleanup functions not executed in 2.0.0b7 fix use_async_effect cleanup not executed when dependencies change Jan 24, 2026
@Archmonger Archmonger marked this pull request as ready for review January 24, 2026 22:28
@Archmonger Archmonger merged commit d07e25e into reactive-python:main Jan 24, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use_async_effect cleanup not executed when dependencies change

1 participant